@cmsbuild ping?

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37308/28946

• This PR adds an extra 20KB to repository

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoTracker/FinalTrackSelectors (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild please test

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d8b7a/23291/summary.html
COMMIT: 9b89f54
CMSSW: CMSSW_12_4_X_2022-03-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37308/23291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
534.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9d8b7a/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 51911
• DQMHistoTests: Total nulls: 59
• DQMHistoTests: Total successes: 3643658
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

as before, I'm running UBSAN offline to confirm, ETA 1 day.

+reconstruction

• technical bugfix
• confirmed the UBSAN error goes away

Thank you @mmusich
Not for this PR (I'll merge it as soon as bot resurrects...), but taking into account the static analizer reported logic error that vector algo could have size 0 at L472 of TrackListMerger.cc, shouldn't a check for ngood>1 be anticipated before that line, instead of having it later at L507?

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

+1

@perrotta

but taking into account the static analizer reported logic error that vector algo could have size 0 at L472 of TrackListMerger.cc, shouldn't a check for ngood>1 be anticipated before that line, instead of having it later at L507?

The issue is already there in IBs:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_12_4_X_2022-03-24-2300/slc7_amd64_gcc10/llvm-analysis/index.html

I can take care of it with some other clean-up at a later time. I gather it's not a request for an immediate fix.